fix EscalateStandbyCcmCc::Execute

[MrGuin]

Close https://github.com/eloqdata/project_tracker/issues/111.

Summary by CodeRabbit

• Bug Fixes
  • Modified request completion handling to properly signal completion status, ensuring correct request lifecycle management and queuing behavior.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

A single method in the escalate standby CCM control change flow is modified to return false instead of true after calling SetFinish(). The actual finishing logic executes unchanged, but the return status signal to the caller is inverted, affecting downstream request lifecycle handling.

Changes

Cohort / File(s)	Summary
Return value modification tx_service/include/cc/cc_request.h	EscalateStandbyCcmCc::Execute() return value changed from true to false after SetFinish() invocation; completion handling remains intact but completion status signal to caller is inverted

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix EscalateStandbyCcmCc: do not set commit_ts when cce is in Unknown status #304: Also modifies EscalateStandbyCcmCc::Execute method, addressing status-based commit_ts and buffered-command handling alongside control-flow changes.

Suggested reviewers

• liunyl

Poem

🐰 A flip of the flag, so small yet refined,
False where true was—a change redefined,
The finish still calls, the logic's the same,
But signals now whisper a different name! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix_esc_cc

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d44114 and 4c12fae.

📒 Files selected for processing (1)

• tx_service/include/cc/cc_request.h

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}