Skip to content

feat: automatically config disk size for eloqstore#414

Merged
thweetkomputer merged 5 commits into
mainfrom
feat-eloqstore-auto-disksize-zc
Feb 26, 2026
Merged

feat: automatically config disk size for eloqstore#414
thweetkomputer merged 5 commits into
mainfrom
feat-eloqstore-auto-disksize-zc

Conversation

@thweetkomputer

@thweetkomputer thweetkomputer commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

Here are some reminders before you submit the pull request

  • Add tests for the change
  • Document changes
  • Reference the link of issue using fixes eloqdb/tx_service#issue_id
  • Reference the link of RFC if exists
  • Pass ./mtr --suite=mono_main,mono_multi,mono_basic

Summary by CodeRabbit

Release Notes

  • New Features

    • Automatic storage space limit derivation: The system now intelligently calculates appropriate local storage limits based on available disk capacity when no explicit configuration is provided.
    • Improved disk capacity reporting with human-readable storage size formatting.
  • Chores

    • Updated internal library components.
    • fix compile warnings.

@coderabbitai

coderabbitai Bot commented Feb 24, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@thweetkomputer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 38 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 8b17c93 and 1bbc3bc.

📒 Files selected for processing (1)
  • tx_service/src/cc/cc_shard.cpp

Walkthrough

The PR adds automatic local storage space calculation capabilities to EloqStore configuration, introduces disk capacity analysis helper utilities, and includes a new reopen_task.cpp source file in the build configuration alongside a submodule commit reference update.

Changes

Cohort / File(s) Summary
Build Configuration
store_handler/eloq_data_store_service/build_eloq_store.cmake
Added src/tasks/reopen_task.cpp to ELOQ_STORE_SOURCES, expanding the compiled sources for the eloqstore static library.
Configuration and Storage Helpers
store_handler/eloq_data_store_service/eloq_store_config.cpp
Introduced auto-derivation of local_space_limit based on available disk capacity across multiple storage paths. Added helper utilities: HumanReadableBytes() for formatted byte output, ResolveExistingPath() for path resolution, DiskCapacitySummary struct, and CalculateAutoLocalSpaceLimit() for computing usable space with device deduplication and 80% capacity ratio.
Submodule Update
store_handler/eloq_data_store_service/eloqstore
Updated eloqstore submodule commit reference from 6ca2571 to b90fc95.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • liunyl
  • lzxddz

Poem

🐰 A rabbit hops with glee so bright,
Auto-sizing disks, oh what a sight!
From bytes to human-friendly display,
Storage limits calculated each day,
Multi-paths now dance in harmony! 🎉

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only a pre-submission checklist template with unchecked items and lacks actual implementation details, context, rationale, or completion status. Replace the template checklist with substantive description of the feature: explain what automatic disk sizing does, why it's needed, how it works, and confirm which checklist items are complete.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: automatically config disk size for eloqstore' clearly and concisely describes the main feature being added—automatic disk size configuration for eloqstore.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-eloqstore-auto-disksize-zc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thweetkomputer thweetkomputer force-pushed the feat-eloqstore-auto-disksize-zc branch from 9e1ee56 to 8b17c93 Compare February 26, 2026 03:52
@thweetkomputer thweetkomputer merged commit 962933b into main Feb 26, 2026
4 checks passed
@thweetkomputer thweetkomputer deleted the feat-eloqstore-auto-disksize-zc branch February 26, 2026 04:05
@coderabbitai coderabbitai Bot mentioned this pull request Mar 18, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants