Skip to content

chore: update submodule eloqstore#467

Merged
thweetkomputer merged 2 commits into
mainfrom
fix-eloqstore-log
Mar 20, 2026
Merged

chore: update submodule eloqstore#467
thweetkomputer merged 2 commits into
mainfrom
fix-eloqstore-log

Conversation

@thweetkomputer

@thweetkomputer thweetkomputer commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

Here are some reminders before you submit the pull request

  • Add tests for the change
  • Document changes
  • Reference the link of issue using fixes eloqdb/tx_service#issue_id
  • Reference the link of RFC if exists
  • Pass ./mtr --suite=mono_main,mono_multi,mono_basic

Summary by CodeRabbit

  • Chores
    • Updated internal submodule dependency to latest version.

@coderabbitai

coderabbitai Bot commented Mar 20, 2026

Copy link
Copy Markdown

Walkthrough

The submodule pointer for store_handler/eloq_data_store_service/eloqstore is updated to reference a new commit. This change pins the repository to a different version of the eloqstore dependency without modifying any local source code.

Changes

Cohort / File(s) Summary
Submodule Reference Update
store_handler/eloq_data_store_service/eloqstore
Submodule commit pointer updated from 12bffb1 to 08a4021, updating the pinned version of the eloqstore dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • MrGuin
  • liunyl

Poem

🐰 Hop, hop, a pointer takes flight,
To a newer commit, shiny and bright,
Dependencies dance in the git tree so tall,
eloqstore beckons, we answer the call! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template checklist with all items unchecked, providing no substantive explanation of the submodule update, reasoning, or issue references. Fill in the checklist items or provide a detailed description explaining why the submodule was updated, which commit/version it references, and what testing was performed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating the eloqstore submodule to a new commit version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-eloqstore-log
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@store_handler/eloq_data_store_service/eloqstore`:
- Line 1: The eloqstore submodule pointer references commit
08a40218438c9b512282716d7c67c2ff8427b955 which is not present in the remote
(fatal: upload-pack: not our ref); confirm the SHA exists in the eloqstore
repository and has been pushed to the correct branch, or if it’s a local WIP
commit, push/merge it into the remote branch used by the submodule; once the
commit is available remotely, update the submodule reference in the parent repo
to point at that commit (or change the submodule to a valid existing
commit/branch) and commit the updated submodule pointer so the submodule update
can succeed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 071e69d6-f250-4542-a5f1-481860565571

📥 Commits

Reviewing files that changed from the base of the PR and between 195439f and 43b6bf4.

📒 Files selected for processing (1)
  • store_handler/eloq_data_store_service/eloqstore

@@ -1 +1 @@
Subproject commit 12bffb1db8e4369026a28bf892e84c18b50fab36
Subproject commit 08a40218438c9b512282716d7c67c2ff8427b955

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify the submodule commit is accessible and show its details
cd store_handler/eloq_data_store_service/eloqstore 2>/dev/null || exit 1

# Show the commit details for the new submodule reference
git log -1 --oneline 08a40218438c9b512282716d7c67c2ff8427b955

# Show the commit message and changed files
git show --stat 08a40218438c9b512282716d7c67c2ff8427b955 | head -30

Repository: eloqdata/tx_service

Length of output: 406


Submodule update cannot proceed—commit not found in repository.

The commit 08a40218438c9b512282716d7c67c2ff8427b955 is not accessible in the eloqstore submodule repository. The system returns: "fatal: remote error: upload-pack: not our ref".

This blocks the update. Before merging, verify:

  1. The commit SHA is correct and exists in the eloqstore repository.
  2. The commit has been pushed to the appropriate branch.
  3. If this is a work-in-progress commit, ensure it's properly committed and available before updating the submodule pointer.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@store_handler/eloq_data_store_service/eloqstore` at line 1, The eloqstore
submodule pointer references commit 08a40218438c9b512282716d7c67c2ff8427b955
which is not present in the remote (fatal: upload-pack: not our ref); confirm
the SHA exists in the eloqstore repository and has been pushed to the correct
branch, or if it’s a local WIP commit, push/merge it into the remote branch used
by the submodule; once the commit is available remotely, update the submodule
reference in the parent repo to point at that commit (or change the submodule to
a valid existing commit/branch) and commit the updated submodule pointer so the
submodule update can succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants