Skip to content

chore: bump eloqstore submodule to latest main#511

Merged
liunyl merged 1 commit into
mainfrom
chore/bump-eloqstore-455
Jun 21, 2026
Merged

chore: bump eloqstore submodule to latest main#511
liunyl merged 1 commit into
mainfrom
chore/bump-eloqstore-455

Conversation

@liunyl

@liunyl liunyl commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Updates the eloqstore submodule (store_handler/eloq_data_store_service/eloqstore) from ba590d9 to 44d7242 (eloqstore main).

This picks up eloqstore #455perf(compaction/gc): cut worker-thread occupation that stalls foreground serving:

  • Cooperative time-budgeted yield (MaybeYield / eloqstore_yield_budget_us) for long-running compaction/GC loops, so a single non-yielding segment no longer stalls foreground serving on the shared shard worker thread.
  • Chunked IouringMgr::CloseFiles / DeleteFiles (128-op batches with WaitIo between).
  • Skip the active branch's redundant manifest replay in file GC.
  • Two GC in-flight-guard correctness fixes (seed from the live allocator high-water; seed no guard for a stub RootMeta).

Submodule-pointer change only. eloqstore #455 passed its own full CI; tx_service CI validates the integration here.

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies.

Updates store_handler/eloq_data_store_service/eloqstore from ba590d9 to
44d7242, picking up eloqstore #455 (perf(compaction/gc): cut worker-thread
occupation that stalls foreground serving) -- the cooperative time-budgeted
yield, chunked Close/DeleteFiles, manifest-replay skip, and the two GC
in-flight-guard correctness fixes.
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e16a0490-5cea-40cd-8f71-4ef6976240dd

📥 Commits

Reviewing files that changed from the base of the PR and between fdf7eb5 and 0341dde.

📒 Files selected for processing (1)
  • store_handler/eloq_data_store_service/eloqstore

Walkthrough

The eloqstore Git submodule pointer under store_handler/eloq_data_store_service/eloqstore is advanced from commit ba590d9b0f319e81ac4532b9b58d9dd1edec90cd to commit 44d7242cdf62ca582afbce72b243a34cde259f83. No other files are modified.

Changes

eloqstore Submodule Bump

Layer / File(s) Summary
eloqstore submodule pointer
store_handler/eloq_data_store_service/eloqstore
Submodule reference updated to a new commit SHA with no other changes in the parent repository.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • eloqdata/tx_service#510: Immediately preceding submodule bump for the same eloqstore path, moving to the commit that this PR supersedes.
  • eloqdata/tx_service#474: Updates the same store_handler/eloq_data_store_service/eloqstore submodule pointer to a different commit.
  • eloqdata/tx_service#471: Also bumps the eloqstore submodule pointer at the same path with no other parent-repo changes.

Suggested reviewers

  • liangjchen
  • MrGuin

Poem

🐇 A tiny pointer, a brand new hash,
The submodule leaps in a lightning flash.
One line changed, so neat and small,
Yet onward the eloqstore rolls through the hall.
Hippity-hop, the commit's in place! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is comprehensive with detailed technical context, but does not follow the template structure with required checklist items. Consider adding the template checklist items and explicitly addressing whether each is applicable (e.g., marking N/A for tests since this is a submodule bump).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: a submodule bump to the latest version on main branch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-eloqstore-455

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@liunyl liunyl merged commit eea6b87 into main Jun 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants