ERR_CHILD_PROCESS_STDIO_MAXBUFFER

[loginovma]

Got this when running ember-cli-update --to 3.10.1 in large monorepo.

{ RangeError [ERR_CHILD_PROCESS_STDIO_MAXBUFFER]: stdout maxBuffer length exceeded
    at Socket.onChildStdout (child_process.js:348:14)
    at Socket.emit (events.js:182:13)
    at addChunk (_stream_readable.js:283:12)
    at readableAddChunk (_stream_readable.js:260:13)
    at Socket.Readable.push (_stream_readable.js:219:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:94:17)
  cmd: 'git ls-files',
  stdout: '-long-string-with-filenames-here-'

[robclancy]

Yep just went to update and got this.

[robclancy]

I was able to fix it by changing this:

https://github.com/kellyselden/git-diff-apply/blob/47ff095ca65f81e7ceae698666a52908f79222a2/src/git-remove-all.js#L12

let files = (await run('git ls-files', Object.assign({ maxBuffer: 1024 * 500 }, options))).trim().split(/\r?\n/g);

[michaelst]

I am also running into this same issue

[tfazekas]

I was able to fix it by changing this:

https://github.com/kellyselden/git-diff-apply/blob/47ff095ca65f81e7ceae698666a52908f79222a2/src/git-remove-all.js#L12

let files = (await run('git ls-files', Object.assign({ maxBuffer: 1024 * 500 }, options))).trim().split(/\r?\n/g);

Could you tell what cause the problem and how you resolved this?
Haven't found anything related to git-diff-apply
I have the same issue, but don't really know what should I change or which file.
Thanks

[koopa]

@tfazekas I was just looking for this myself, maybe this helps:
cd $(npm list -g | head -n1)/node_modules/ember-cli-update/node_modules/git-diff-apply

PS: setting a large maxBuffer size indeed fixed this issue for me as well.

[tfazekas]

Thanks @koopa !

[kellyselden]

I used @robclancy's suggestion. Can you try with v0.34.13 and report back?

[bryanhickerson]

I still have this issue as of 0.43.6.

$ ember-cli-update --to "3.11.0"
{ RangeError [ERR_CHILD_PROCESS_STDIO_MAXBUFFER]: stdout maxBuffer length exceeded
    at Socket.onChildStdout (child_process.js:354:14)
    at Socket.emit (events.js:198:13)
    at addChunk (_stream_readable.js:288:12)
    at readableAddChunk (_stream_readable.js:265:13)
    at Socket.Readable.push (_stream_readable.js:224:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:94:17)
  cmd: 'git commit -m "message" --no-verify',
$ ember-cli-update --version
0.43.6

[bryanhickerson]

I still have this issue as of 0.43.6.

Issue didn't happen in the upgrade from 3.11 to 3.12

[timiyay]

We've just encountered this error when also running in a large Ember monorepo.

@kellyselden WDYT about maxing the maxBuffer into a CLI param for ember-cli-update?

That would free us up to experiment with a maxBuffer size that suits our repo, while allowing you to maintain sensible defaults.

If that sounds agreeable, I can get a PR together.

[timiyay]

I've since seen the git-diff-apply PR that switches to spawn to, theoretically, sidestep any max buffer issues: kellyselden/git-diff-apply#278.

Unfortunately, we're still encountering the max buffer issue, when attempting to upgrade from Ember 3.10 to 3.11. I've done some light digging into docs and help forums, and the consensus seems to be that spawn is exempt from buffer issues. Either that's not true, or something else in the chain is trying to swallow the entire stdout in one go.

ember-cli-update: 0.47.1
nodejs: 10.15.0

{ RangeError [ERR_CHILD_PROCESS_STDIO_MAXBUFFER]: stdout maxBuffer length exceeded
    at Socket.onChildStdout (child_process.js:348:14)
    at Socket.emit (events.js:182:13)
    at addChunk (_stream_readable.js:283:12)
    at readableAddChunk (_stream_readable.js:260:13)
    at Socket.Readable.push (_stream_readable.js:219:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:94:17)
  cmd: 'git commit -m "message" --no-verify',
  stdout: 'very-large-showstopping-output',
  stderr: ''
}

Update: looks like our issue is coming from an attempted large git commit operation, which still uses the exec command, and is therefore subject to the maxBuffer problems in this issue. The relevant code is here: https://github.com/ejlangev/git-diff-apply/blob/master/src/run.js#L9

If there's a preference for configurable maxBuffer VS using spawn+streams, I'd be interested to hear, and I can take a swing at a PR.