[PATCH] Throw error for non Ember CLI project#123
Merged
kellyselden merged 1 commit intoember-cli:masterfrom Sep 15, 2017
Merged
[PATCH] Throw error for non Ember CLI project#123kellyselden merged 1 commit intoember-cli:masterfrom
kellyselden merged 1 commit intoember-cli:masterfrom
Conversation
kellyselden
requested changes
Sep 13, 2017
| let packageVersion = getPackageVersion('.'); | ||
|
|
||
| if (!packageVersion) { | ||
| console.error('Ember CLI was not found in this project\'s package.json'); |
Member
There was a problem hiding this comment.
All console logging happens in bin/ember-cli-update.js. We should return a rejected promise here.
akashdsouza
force-pushed
the
patch_error_non_ember_cli_projects
branch
from
8d44fe9 to
efaabee
Compare
kellyselden
requested changes
Sep 14, 2017
Member
kellyselden
left a comment
kellyselden
left a comment
There was a problem hiding this comment.
One last thing then good.
| let packageVersion = getPackageVersion('.'); | ||
|
|
||
| if (!packageVersion) { | ||
| return new Promise((_, reject) => reject('Ember CLI was not found in this project\'s package.json')); |
Member
There was a problem hiding this comment.
This can be Promise.reject('Ember CLI was not found in this project\'s package.json') like https://github.com/kellyselden/git-diff-apply/blob/v0.3.1/src/index.js#L25
akashdsouza
force-pushed
the
patch_error_non_ember_cli_projects
branch
from
efaabee to
0bc22da
Compare
kellyselden
approved these changes
Sep 15, 2017
Member
|
Perfect! Thanks |
Member
|
Queued for release in v0.6.8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#116