Support Detection of Ember/Glimmer apps as dependencies#524
Merged
kellyselden merged 2 commits intoember-cli:masterfrom Mar 11, 2019
elwayman02:support-dependency-detection
Merged
Support Detection of Ember/Glimmer apps as dependencies#524kellyselden merged 2 commits intoember-cli:masterfrom elwayman02:support-dependency-detection
kellyselden merged 2 commits intoember-cli:masterfrom
elwayman02:support-dependency-detection
Conversation
This change allows ember-cli/glimmer to be specified as either a dependency or devDependency of the project being updated. Currently, `ember-cli-update` throws an error in some instances, since it is only checking devDependencies.
kellyselden
reviewed
Mar 11, 2019
|
|
||
| if (devDependencies) { | ||
| let isGlimmer = devDependencies['@glimmer/blueprint']; | ||
| if (dependencies || devDependencies) { |
Member
There was a problem hiding this comment.
I think the Object.assign eliminated the need for this conditional.
kellyselden
requested changes
Mar 11, 2019
Member
kellyselden
left a comment
kellyselden
left a comment
There was a problem hiding this comment.
One tweak then good to merge!
kellyselden
approved these changes
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows ember-cli/glimmer to be specified as either a dependency
or devDependency of the project being updated. Currently,
ember-cli-updatethrows an error in some instances, since it is only checking devDependencies.