EmberApp specific helper for an upgradeable default brocfile.#396
Merged
stefanpenner merged 2 commits intomasterfrom Apr 21, 2014
Merged
EmberApp specific helper for an upgradeable default brocfile.#396stefanpenner merged 2 commits intomasterfrom
stefanpenner merged 2 commits intomasterfrom
Conversation
Member
There was a problem hiding this comment.
Could we add this to the prototype to make it easier to use from custom trees (and possible override)?
Contributor
Author
There was a problem hiding this comment.
nah, I consider this still a hack. Once we have a proper solution for this, i will expose that.
Most if not all features should still be available
stefanpenner
added a commit
that referenced
this pull request
Apr 21, 2014
EmberApp specific helper for an upgradeable default brocfile.
2 tasks
Member
|
@stefanpenner - Excellent work here. From all of our users everywhere: Thank you! |
Contributor
Author
|
@rjackson I hope this to be a foundation for us to iterate on. |
This was referenced Apr 21, 2014
Member
There was a problem hiding this comment.
@stefanpenner This file is not being picked. /assets/qunit.css returns not found.
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been a common pain point during upgrades, also a little intimidating for early users.
The goal for this is not to hide broccoli, as custom usage should not be discouraged.
Anything reasonable that now cannot be done should be considered a bugfix.
Most if not all features should still be available
Please note, as we improve our add-on story the
legacyFilesToAppend+ignoredModules+ignoredModulesshould vanish.Likely what it would look like today (without the addon work)
Once we have a better add-on solution it will eventually look more like: