Prevent errors when fastboot-body-end is not present.#763
Merged
Conversation
The current implementation of `clear-double-render` guards for when `fastboot-body-start` is not present, but does not check if `fastboot-body-end` is present before attempting to remove it (therefore causing an `Cannot call 'parentElement' of null` error). Note: There are still some issues with this approach (e.g. why is `fastboot-body-start` present but `fastboot-body-end` is missing), and this change does not directly address all of the issues. It **does** prevent a masking error from happening.
Contributor
|
@rwjblue just FYI and for future travelers: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
clear-double-renderguards for whenfastboot-body-startis not present, but does not check iffastboot-body-endis present before attempting to remove it (therefore causing anCannot call 'parentElement' of nullerror).Note: There are still some issues with this approach (e.g. why is
fastboot-body-startpresent butfastboot-body-endis missing), and this change does not directly address all of the issues. It does prevent a masking error from happening.