Merged
Conversation
…the test-packages
kiwiupover
commented
Jul 31, 2020
rwjblue
reviewed
Jul 31, 2020
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Looks really good, only one change needed (I think)...
Member
Author
|
@rwjblue the legacy mocha tests are passing after switching to use This is ready for you the have run a couple of times without issues. |
rwjblue
approved these changes
Jul 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
basic-appto the test-packages to represent a basic ember app that is fastbooted usingember-cli-fastbootMost of the new test will be against the basic-app.
This PR also replaces
ember-cli-fastboot/test/build-test.jswith https://github.com/ember-fastboot/ember-cli-fastboot/pull/775/files#diff-518e8f29120d406a1931ce09ccca5d27