Fix treeForFastBoot when project is an addon#808
Merged
rwjblue merged 1 commit intoember-fastboot:masterfrom Jan 29, 2021
Merged
Fix treeForFastBoot when project is an addon#808rwjblue merged 1 commit intoember-fastboot:masterfrom
rwjblue merged 1 commit intoember-fastboot:masterfrom
Conversation
kiwiupover
reviewed
Jan 25, 2021
| const projectFastbootPath = path.join(this.project.root, 'fastboot'); | ||
| if (this.existsSync(projectFastbootPath)) { | ||
| // ignore the project's fastboot folder if we are an addon, as that is already handled above | ||
| if (!this.project.isEmberCLIAddon() && this.existsSync(projectFastbootPath)) { |
Member
There was a problem hiding this comment.
@simonihmig it would be great to add a test for this. Seems like we will need to add a test-package app that consumes an addon that uses ember-cli-fastboot
#805 is going to change this repos structure over the next week. We may need to rebase this PR then we can get it merged.
kiwiupover
approved these changes
Jan 29, 2021
Member
|
@simonihmig thanks for you PR |
rwjblue
approved these changes
Jan 29, 2021
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Chatted with @xg-wang and @kiwiupover in todays FastBoot meeting, @kiwiupover is going to work on adding a full dummy app test project so that this code is properly undertest. But we are going to merge this in while he works on that, since the code seems correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #807
Tested locally in an addon.