Add a default state for metadata#840
Merged
suchitadoshi1987 merged 6 commits intomasterfrom Aug 3, 2021
Merged
Conversation
Contributor
|
Should we add a test for the default value ? This way in future if we accidentally change this, then we have a test to back this up. |
Contributor
|
Also would be good to run this by @rwjblue first |
Member
Author
|
cc @rwjblue |
Member
Author
yup. added tests to ensure ^^ |
Contributor
|
LGTM! thanks for adding the tests |
Member
|
@suchitadoshi1987 I think we need to avoid creating new test fixtures here. I'll DM you to figure out the unit test or use a proper test app |
xg-wang
approved these changes
Aug 3, 2021
Member
|
@suchitadoshi1987 looks like this change broke existing test https://github.com/ember-fastboot/ember-cli-fastboot/pull/843/checks?check_run_id=3259458760 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently ember addons that rely on certain metadata from fastboot service that depends on a transitive dependency that sets this metadata will run into issues during local development against a dummy app.
This PR adds the default value of the metadata so that the invocation of the meta doesnt hard fail.