Add tests for Ember 3.24 + 3.28 + 4.0#861
Merged
rwjblue merged 3 commits intoember-fastboot:masterfrom Oct 19, 2021
Merged
Conversation
kiwiupover
approved these changes
Oct 10, 2021
Member
kiwiupover
left a comment
kiwiupover
left a comment
There was a problem hiding this comment.
@NullVoxPopuli you will need to fix the conflicts.
NullVoxPopuli
force-pushed
the
support-ember-4
branch
from
a4198a9 to
4a085d9
Compare
Contributor
Author
|
done! |
|
@kiwiupover needs an approve to run ci |
| @@ -0,0 +1,19037 @@ | |||
| Arguments: | |||
Contributor
There was a problem hiding this comment.
@NullVoxPopuli I assume this file should be removed and not be committed?
Contributor
Author
There was a problem hiding this comment.
yeah, I guess I assumed everyone had this in your .gitignore
Contributor
|
@NullVoxPopuli #858 landed, so you may need to rebase |
NullVoxPopuli
force-pushed
the
support-ember-4
branch
from
4a085d9 to
8bd8a15
Compare
rwjblue
approved these changes
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: #858