Update .npmignore to ignore .github and test folders#865
Merged
mansona merged 1 commit intoember-fastboot:masterfrom Jan 12, 2022
Merged
Update .npmignore to ignore .github and test folders#865mansona merged 1 commit intoember-fastboot:masterfrom
mansona merged 1 commit intoember-fastboot:masterfrom
Conversation
mansona
approved these changes
Jan 12, 2022
Member
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
So usually I would say that this sort of change isn't really that important since a) the "unpacked size" isn't all that representative of reality most of the time in the ember world and b) it matters less with something that is more of a server technology.
In this case there is literally no downside so I'm going to merge it 👍
Contributor
Author
|
@mansona totally agree with you! This is just to keep things tidy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shrinks the "unpacked size" for a few Kb