Skip to content

Update and synchronize dependencies in the monorepo#886

Merged
mansona merged 1 commit intoember-fastboot:masterfrom
SergeAstapov:bump-deps
Jan 28, 2022
Merged

Update and synchronize dependencies in the monorepo#886
mansona merged 1 commit intoember-fastboot:masterfrom
SergeAstapov:bump-deps

Conversation

@SergeAstapov
Copy link
Contributor

No description provided.

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just "requesting changes" on this because we probably need a discussion before it's ok to ship. And it's only one dependency on one project that I'm curious about too

@mansona mansona merged commit be7ff2f into ember-fastboot:master Jan 28, 2022
@SergeAstapov SergeAstapov deleted the bump-deps branch January 28, 2022 17:34
@SergeAstapov
Copy link
Contributor Author

Discussed with @mansona and bumping jsdom should not be a concern as we use it only to parse an html for config/environment and manifest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants