Remove deprecated implicit-injections#904
Merged
ef4 merged 2 commits intoember-fastboot:masterfrom Dec 8, 2022
Merged
Conversation
Contributor
|
I'm going to assume this is a breaking change since anybody who was relying on the implicit injections will need to do their own explicit injections. (Which is fine because I'm also assuming that the previous PR dropping old node versions is a breaking change.) |
Collaborator
|
@ef4 yes the last two PRs will need to be released as a new major |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same idea as #900, but also tests against 4.4.
This should fix the Ember 4 deprecations in #869.