Convert to V2 Addon, add types

[aklkv]

No description provided.

[kategengler]

This drops testing of Ember < 5.8

[NullVoxPopuli]

aye, that's the default in the blueprint: https://github.com/ember-cli/ember-addon-blueprint/blob/main/files/.try.mjs#L29

this is def still a breaking change tho, as there was no ember-auto-import requirement before, and at least ember-auto-import will be required now

[kategengler]

aye, that's the default in the blueprint: [ember-cli/ember-addon-blueprint@main/files/.try.mjs#L29]

Yes, I am noting it for later use in the CHANGELOG

[NullVoxPopuli]

nice

[NullVoxPopuli]

nice

[NullVoxPopuli]

nice!

[aklkv]

@NullVoxPopuli @kategengler any chance we can land this?

[kategengler]

I'm 👍 except for those eslint changes I proposed.

Generally, though, I think it is silly that we are converting barely touched addons to the v2 format before it is default for anybody generating an addon because it means we will have to expend effort to convert this addon again to the final format.

[NullVoxPopuli]

the v1 addon format is actively harmful for new projects tho

I dunno if it's the exact same, but it seems the fact that so many people want v2 addons kinda show that we're potentially repeating the mistake we made with holding out on embroider for so long

[kategengler]

I agree, v2 addons needed to be the default a long time ago.

[kategengler]

Noticed No CI ran here, I just re-enabled the workflow, could you kick it so it runs?

[NullVoxPopuli]

closing and re-open will re-start ci as well

[NullVoxPopuli]

I checked that the implementations were the exact same, and they are -- so I'm good with this moving forward -- README updates are good too.

everything is just applying the v2 addon blueprint from ember-cli/ember-addon-blueprint (the blueprint being proposed for default)

CI is green now 🎉