fix: backward compatability for did-update#92
Open
aklkv wants to merge 1 commit intoemberjs:masterfrom
Open
Conversation
NullVoxPopuli
requested changes
Apr 13, 2026
Contributor
NullVoxPopuli
left a comment
There was a problem hiding this comment.
Don't we want the original macro conditions?
const untrack = (function () {
if (macroCondition(dependencySatisfies('ember-source', '> 3.27.0-beta.1'))) {
// ember-source@3.27 shipped "real modules" by default, so we can just use
// importSync to get @glimmer/validator directly
return importSync('@glimmer/validator').untrack;
} else if (
macroCondition(dependencySatisfies('ember-source', '>= 3.22.0-alpha.1'))
) {
// we can access `window.Ember` here because it wasn't deprecated until at least 3.27
// eslint-disable-next-line no-undef
return Ember.__loader.require('@glimmer/validator').untrack;
} else {
// nothing needed here, we do not call `untrack` in this case
}
})();
Contributor
Author
|
yeah my thought was the same initially but I re-tested the original macro path and confirmed it still fails at runtime in the consumer (same DidUpdateModifier tracking assertion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as part of modernization I broke compatibility layer on did-update, this adds it back in self contained way