Start breaking up Ember.View code into mixins based on purpose#10320
Merged
mmun merged 6 commits intoemberjs:masterfrom Jan 31, 2015
Merged
Start breaking up Ember.View code into mixins based on purpose#10320mmun merged 6 commits intoemberjs:masterfrom
mmun merged 6 commits intoemberjs:masterfrom
Conversation
Contributor
|
I'm curious, what's the purpose of this refactoring? Do you think these could be used outside of View or is it more for separation of concerns? |
Member
Author
|
@drogus I'm working on "metal views", the view layer performance improvements. Generally, I think it's useful to break apart massive classes such as Ember.View into their logical pieces so you can easily see how things fit together. |
…so it can be used elsewhere
mmun
added a commit
that referenced
this pull request
Jan 31, 2015
Start breaking up Ember.View code into mixins based on purpose
Member
|
I'd like to see these mixins in separate files instead of all in the same place, but clearly that can be a later refactoring. |
Contributor
Sounds great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mmun @krisselden