Merged
Conversation
mmun
force-pushed
the
inclusive-morph
branch
from
375ff4f to
87251db
Compare
Member
|
We are super early in the cycle, and inclusive morph fixes many bugs, should we land it in 1.11.0-beta.2? |
Member
|
I vote yes :) |
Member
|
I think including this in 1.11.0-beta.2 is very important. If we do not include it we will have to maintain two different rendering processes (HTMLBars 0.10 and 0.11+), and it would be nice to take advantage of the improvements being done in HTMLBars throughout the beta cycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP to get working with inclusive morph refactor.
Most tests are fixed, when I run locally I have 10694 assertions of 10708 passed, 14 failed.
@mmun and @wycats