[CLEANUP beta] Remove metaPath, getMeta and setMeta#11750
Merged
krisselden merged 1 commit intoemberjs:masterfrom Jul 19, 2015
Merged
[CLEANUP beta] Remove metaPath, getMeta and setMeta#11750krisselden merged 1 commit intoemberjs:masterfrom
metaPath, getMeta and setMeta#11750krisselden merged 1 commit intoemberjs:masterfrom
Conversation
`metaPath` had been deprecated. `setMeta` and `getMeta` were not being used at all... must of been leftover cruft.
duggiefresh
force-pushed
the
cleanup-remove-metaPath
branch
from
7226e15 to
7eb9eb3
Compare
Member
|
I believe it was just used by the old ac/rc code |
Member
|
Get get and set meta where exposed and not deprecated. We may need to deprecate them? Thoughts @rwjblue ? |
Member
|
@stefanpenner Speaking of which, we can remove ember.js/packages/ember-metal/lib/utils.js Line 290 in 7a8a46b |
Contributor
|
These were internal, used briefly by Ember Data, but have been unused a while. |
krisselden
added a commit
that referenced
this pull request
Jul 19, 2015
[CLEANUP beta] Remove `metaPath`, `getMeta` and `setMeta`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metaPathhad been deprecated.setMetaandgetMetawere notbeing used at all... must of been leftover cruft.