[BUGFIX beta] Avoid using .env property on components.#13911
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Jul 27, 2016
Merged
[BUGFIX beta] Avoid using .env property on components.#13911rwjblue merged 1 commit intoemberjs:masterfrom
.env property on components.#13911rwjblue merged 1 commit intoemberjs:masterfrom
Conversation
Member
Author
|
@krisselden - Would you mind reviewing? |
Contributor
|
LGTM, I'd rather put all the view stuff into one thing, but this is a step in the right direction. |
Member
Author
|
@krisselden - Ya, I will try to find time next week to work on the view meta stuff we have been chatting about (I think that is better than stashing more things on the views themselves like this). Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13907