[Cleanup] Introduce a tiny bit more debugging data to warnings about CP dependencies#15106
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Apr 4, 2017
trek:tell-you-what-you-passed
Merged
[Cleanup] Introduce a tiny bit more debugging data to warnings about CP dependencies#15106rwjblue merged 1 commit intoemberjs:masterfrom trek:tell-you-what-you-passed
rwjblue merged 1 commit intoemberjs:masterfrom
trek:tell-you-what-you-passed
Conversation
Member
|
Awesome, thank you @trek! |
Member
Author
|
👋 long time no commit. |
Contributor
|
Such emeritus 😘 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran across this updating an app from 2.4LTS to 2.5.
We started with code a bit like this:
And mutated to:
Then we started the 2.4 -> 2.5 update in our app.
In 2.5, Ember started protecting from this error by checking
typeoffor dependencies and asserting if you passed other types. It was a little rough to track down with only "A computed property key must be a string" as a guide.This PR updates the assertion with a tiny bit more debugging data.