[BUGFIX release] Correct until values for this.container deprecations.#15180
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Apr 27, 2017
Merged
[BUGFIX release] Correct until values for this.container deprecations.#15180rwjblue merged 1 commit intoemberjs:masterfrom
until values for this.container deprecations.#15180rwjblue merged 1 commit intoemberjs:masterfrom
Conversation
…ions. These deprecations were added in the Ember 2.3 cycle, before we had established the LTS system and how private API deprecations are handled. Per the rules we created around private API deprecations, the `until` value is supposed to be the version just after the next LTS. In theory, that means this could have been 2.5.0 originally, but I'm updating to 2.13.0 because 2.12 was also an LTS. An emberobserver.com search shows little usage (other than fallbacks when owner is not found), and very few issues are still open around this sort of `.container` deprecation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These deprecations were added in the Ember 2.3 cycle, before we had established the LTS system and how private API deprecations are handled. Per the rules we created around private API deprecations, the
untilvalue is supposed to be the version just after the next LTS. In theory, that means this could have been 2.5.0 originally, but I'm updating to 2.13.0 because 2.12 was also an LTS.An emberobserver.com search shows little usage (other than fallbacks when owner is not found), and very few issues are still open around this sort of
.containerdeprecation.