Remove _lookupFactory support.#15193
Merged
rwjblue merged 3 commits intoemberjs:masterfrom May 1, 2017
Merged
Conversation
Member
Author
|
This is in a similar area but independent of #15192. |
This was referenced Apr 30, 2017
Member
Author
|
Please note that there is one commit that is actually a |
rwjblue
force-pushed
the
remove-lookup-factory
branch
2 times, most recently
from
42bdfa1 to
c6cd7c6
Compare
stefanpenner
approved these changes
May 1, 2017
Member
|
@rwjblue thanks for the cleanup! |
Contributor
|
☔ The latest upstream changes (presumably #15192) made this pull request unmergeable. Please resolve the merge conflicts. |
added 3 commits
May 1, 2017 13:45
These were only around to support `lookupFactory` semantics.
rwjblue
force-pushed
the
remove-lookup-factory
branch
from
c6cd7c6 to
579f857
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was deprecated in Ember 2.12 (which was an LTS version).
This removes
owner._lookupFactoryAPIs completely. It also includesfactory injections, and factory type injections.