[BUGFIX release] Avoid creating event dispatcher in FastBoot with Engines#15695
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Oct 4, 2017
Merged
Conversation
rwjblue
force-pushed
the
avoid-event-manager-in-non-interactive
branch
from
1121a37 to
1d698d6
Compare
…ines Prior to this commit, the `event_dispatcher:main` was always being instantiated so that it can be injected eagerly into child engines. In general, this is good (we should only ever have a single event dispatcher going) but in the FastBoot case the event dispatcher should not have been created at all (since there is no DOM or interactivity booting the event dispatcher to listen to DOM events is wasteful and error prone). This commit updates the EventDispatcher base class to properly look for the `isInteractive` flag (which is what it should have been doing all along) on the `-environment:main` that is injected from the `Application.visit` API. When `isInteractive` is falsey and the event dispatcher is instantiated we will issue an assertion. We also avoid eagerly looking up (and therefore forcing to initialize) the EventDispatcher if `.visit` API is passed `isInteractive: false`. This avoids the specifically reported issue of triggering an assertion in FastBoot mode.
rwjblue
force-pushed
the
avoid-event-manager-in-non-interactive
branch
from
1d698d6 to
6e9a9c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
event_dispatcher:mainwas always being instantiated so that it can be injected eagerly into child engines. In general, this is good (we should only ever have a single event dispatcher going) but in the FastBoot case the event dispatcher should not have been created at all (since there is no DOM or interactivity booting the event dispatcher to listen to DOM events is wasteful and error prone).This commit updates the EventDispatcher base class to properly look for the
isInteractiveflag (which is what it should have been doing all along) on the-environment:mainthat is injected from theApplication.visitAPI. WhenisInteractiveis falsey and the event dispatcher is instantiated we will issue an assertion.We also avoid eagerly looking up (and therefore forcing to initialize) the EventDispatcher if
.visitAPI is passedisInteractive: false. This avoids the specifically reported issue of triggering an assertion in FastBoot mode.Fixes #15615