[CLEANUP beta] Remove Ember.Binding support#16090
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Jan 8, 2018
Merged
Conversation
rwjblue
force-pushed
the
ember-binding
branch
3 times, most recently
from
f2934ce to
90a45f5
Compare
Legacy support for the underlying feature to be moved to ember-2-legacy. After these changes `ember-2-legacy` needs to do the following: * Set `ENV._BINDING_SUPPORT` to `true` * Set `Ember.Mixin.finishPartial` (to the function being removed) * Set `Ember.Mixin.detectBinding` (to the function being removed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy support for the underlying feature to be moved to ember-2-legacy.
After these changes
ember-2-legacyneeds to do the following:ENV._BINDING_SUPPORTtotrueEmber.Mixin.finishPartial(to the function being removed)Ember.Mixin.detectBinding(to the function being removed)