Remove system/lib/libc-sockets.symbols - #11071
Merged
Merged
Conversation
This file was never usrs since symbols files are read from either `system/lib/symbols/wasm/` or `system/lib/symbols/asmjs/` and never from `system/lib`. Also this library is added explicitly via `add_library` and not implicitly based what symbols are needed in the input.
aheejin
approved these changes
May 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file was never used since symbols files are read from either
system/lib/symbols/wasm/orsystem/lib/symbols/asmjs/and neverfrom
system/lib. Also this library is added explicitly viaadd_libraryand not implicitly based what symbols are needed in theinput.
I noticed this when working on the wider change to move away from
symbols files for system libraries: #10998