Move emscripten_stack_get_base/end into native code - #12615
Merged
Conversation
sbc100
force-pushed
the
stack_base_end_native
branch
10 times, most recently
from
October 28, 2020 07:48
548a284 to
fd0326b
Compare
sbc100
changed the title
sbc100
force-pushed
the
stack_base_end_native
branch
from
October 28, 2020 20:21
fd0326b to
7990a97
Compare
kripken
approved these changes
Oct 28, 2020
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
Wow, nice work! lgtm modulo comments&questions
sbc100
force-pushed
the
stack_base_end_native
branch
from
October 28, 2020 20:47
7990a97 to
102d2b2
Compare
sbc100
force-pushed
the
stack_base_end_native
branch
from
October 28, 2020 22:47
102d2b2 to
1b3d023
Compare
dschuff
approved these changes
Oct 29, 2020
With this change, we no longer need any JavaScript variable to track the state of the stack. The base and max as well as the current stack pointer are all managed in native code. The following JavaScript variable a no longer present in the library code: STACK_BASE -> emscripten_stack_get_base() STACK_MAX -> emscripten_stack_get_end() STACKTOP -> emscripten_stack_get_current() TOTAL_STACK -> emscripten_stack_get_base() - emscripten_stack_get_end()
sbc100
force-pushed
the
stack_base_end_native
branch
from
October 29, 2020 01:21
1b3d023 to
d089b12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, we no longer need any JavaScript variable to track the
state of the stack. The base and max as well as the current stack
pointer are all managed in native code.
The following JavaScript variable a no longer present in the library
code: