Conversation
sbc100
approved these changes
May 4, 2021
Collaborator
|
(we don't have test for this?) |
Member
Author
|
Adding a test for this (which I realize we can, as you said - we can't allocate it, but we can test that we report it as the max), I found a bunch of issues here, all related. Added to here. New description: Fix emscripten_get_heap_max's return value for 4GB (do not wrap to 0, return one
|
sbc100
approved these changes
May 4, 2021
Collaborator
|
OK to land this once the ff tests pass? |
sbc100
added a commit
that referenced
this pull request
Jul 12, 2021
Without this change any user of ALLOW_MEMORY_GROWTH with asan would get a rather cryptic error message from the linker: wasm-ld: error: initial memory too small, 278278624 bytes needed This is because asan increases the memory requirements in proportion to the max memory, and the max memory defaults to 2Gb with `ALLOW_MEMORY_GROWTH` enabled. Also, remove check for `MAXIMUM_MEMORY` == -1 which is no longer a thing since #14088. Fixes: #14621
sbc100
added a commit
that referenced
this pull request
Jul 13, 2021
Without this change any user of ALLOW_MEMORY_GROWTH with asan would get a rather cryptic error message from the linker: wasm-ld: error: initial memory too small, 278278624 bytes needed This is because asan increases the memory requirements in proportion to the max memory, and the max memory defaults to 2Gb with `ALLOW_MEMORY_GROWTH` enabled. Also, remove check for `MAXIMUM_MEMORY` == -1 which is no longer a thing since #14088. Fixes: #14621
sbc100
added a commit
that referenced
this pull request
Jul 13, 2021
Without this change any user of ALLOW_MEMORY_GROWTH with asan would get a rather cryptic error message from the linker: wasm-ld: error: initial memory too small, 278278624 bytes needed This is because asan increases the memory requirements in proportion to the max memory, and the max memory defaults to 2Gb with `ALLOW_MEMORY_GROWTH` enabled. Also, remove check for `MAXIMUM_MEMORY` == -1 which is no longer a thing since #14088. Fixes: #14621
sbc100
added a commit
that referenced
this pull request
Jul 13, 2021
Without this change any user of ALLOW_MEMORY_GROWTH with asan would get a rather cryptic error message from the linker: wasm-ld: error: initial memory too small, 278278624 bytes needed This is because asan increases the memory requirements in proportion to the max memory, and the max memory defaults to 2Gb with `ALLOW_MEMORY_GROWTH` enabled. Also, remove check for `MAXIMUM_MEMORY` == -1 which is no longer a thing since #14088. Fixes: #14621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old value here wrapped to 0.