Skip to content

Add a failfast command-line option to runner.py - #15111

Merged
aardappel merged 1 commit into
mainfrom
failfast
Sep 24, 2021
Merged

Add a failfast command-line option to runner.py#15111
aardappel merged 1 commit into
mainfrom
failfast

Conversation

@aardappel

Copy link
Copy Markdown
Collaborator

This is functionality already exposed by TextTestRunner.

This is functionality already exposed by `TextTestRunner`.
@aardappel
aardappel requested a review from kripken September 23, 2021 22:07
@aardappel
aardappel merged commit 63e4ef3 into main Sep 24, 2021
@aardappel
aardappel deleted the failfast branch September 24, 2021 17:00
@sbc100

sbc100 commented Sep 24, 2021

Copy link
Copy Markdown
Collaborator

Thanks for doing this. Does this work with the parallel test runner?

@sbc100

sbc100 commented Sep 24, 2021

Copy link
Copy Markdown
Collaborator

It seems not. For example, if i force all dylink tests to fail then run wasm2 test suite with --failfast it still tries to runs everything it seems:

./tests/runner wasm2 --failfast --skip-slow
...

----------------------------------------------------------------------
Ran 754 tests in 53.236s

FAILED (failures=72, skipped=26)

@sbc100

sbc100 commented Sep 24, 2021

Copy link
Copy Markdown
Collaborator

72 failures.. but ran all 754 tests

@aardappel

Copy link
Copy Markdown
Collaborator Author

Yes, it be nice if it worked with parallel tests too.. I guess I usually have all the test debugging stuff on anyway which turns that off.

@sbc100

sbc100 commented Sep 24, 2021

Copy link
Copy Markdown
Collaborator

Would be cool to combine with some kind of "restart-suite-from-last-failure" feature too.. so one could iterate through the test suite fixing one thing at a time.

@aardappel

Copy link
Copy Markdown
Collaborator Author

that would have saved me a lot of time, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants