Skip to content

Move WasmFS C++ link workaround from test code to emcc.py - #15179

Merged
kripken merged 2 commits into
mainfrom
wasmfscxx
Sep 29, 2021
Merged

Move WasmFS C++ link workaround from test code to emcc.py#15179
kripken merged 2 commits into
mainfrom
wasmfscxx

Conversation

@kripken

@kripken kripken commented Sep 29, 2021

Copy link
Copy Markdown
Member

This way WasmFS can be used outside the test suite as well.

Followup to #15147

@kripken
kripken requested review from ethanalee and sbc100 September 29, 2021 22:05
@kripken kripken changed the title Move WasmFS workaround from test code to emcc.py Move WasmFS C++ link workaround from test code to emcc.py Sep 29, 2021
@kripken
kripken merged commit d48ae60 into main Sep 29, 2021
@kripken
kripken deleted the wasmfscxx branch September 29, 2021 23:13
@kripken

kripken commented Sep 29, 2021

Copy link
Copy Markdown
Member Author

@sbc100 wasm2.test_pthread_nested_work_queue does look like a new flake - I saw it on this PR before the last change, and now it didn't show up. But it did appear twice today in two different places, hm...

@sbc100

sbc100 commented Sep 29, 2021

Copy link
Copy Markdown
Collaborator

If its flaky enough maybe we could bisect it?

@kripken

kripken commented Sep 30, 2021

Copy link
Copy Markdown
Member Author

Hmm, last commits look ok actually... 😄 who knows. Actually, perhaps this was a temporary breakage on tot due to some LLVM change that they reverted, perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants