Avoid using __cxa_thread_atexit for pthread_cleanup_push. - #15210
Merged
Conversation
sbc100
enabled auto-merge (squash)
October 4, 2021 15:47
sbc100
force-pushed
the
avoid___cxa_thread_atexit
branch
from
October 4, 2021 15:59
1f479cf to
2cdcb71
Compare
dschuff
approved these changes
Oct 4, 2021
These is no need to use `__cxa_thread_atexit` here, we can just call these functions during thread exit (which is what musl does). This also avoids references `__cxa_thread_atexit` which is normally a libc++abi symbol from C programs. Needed by (split out from) #14489.
sbc100
force-pushed
the
avoid___cxa_thread_atexit
branch
from
October 4, 2021 17:15
2cdcb71 to
baac32a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These is no need to use
__cxa_thread_atexithere, we can just callthese functions during thread exit (which is what musl does).
This also avoids references
__cxa_thread_atexitwhich is normally alibc++abi symbol from C programs.
Needed by (split out from) #14489.