Skip to content

Remove unnecessary export of emscripten_futex_wake. NFC #15767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Dec 14, 2021
Merged

Remove unnecessary export of emscripten_futex_wake. NFC #15767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion emcc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1951,7 +1951,6 @@ def default_setting(name, new_default):
'__emscripten_thread_init',
'__emscripten_thread_exit',
'_emscripten_tls_init',
'_emscripten_futex_wake',
'_emscripten_current_thread_process_queued_calls',
'_pthread_self',
]
Expand Down
2 changes: 1 addition & 1 deletion src/library_pthread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
var LibraryPThread = {
$PThread__postset: 'if (!ENVIRONMENT_IS_PTHREAD) PThread.initMainThreadBlock();',
$PThread__deps: ['_emscripten_thread_init',
'emscripten_futex_wake', '$killThread',
'$killThread',
'$cancelThread', '$cleanupThread', '$zeroMemory',
'_emscripten_thread_free_data',
'exit',
Expand Down
10 changes: 0 additions & 10 deletions src/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,16 +237,6 @@ self.onmessage = function(e) {
#endif
} catch(ex) {
if (ex != 'unwind') {
#if ASSERTIONS
// FIXME(sbc): Figure out if this is still needed or useful. Its not
// clear to me how this check could ever fail. In order to get into
// this try/catch block at all we have already called bunch of
// functions on `Module`.. why is this one special?
if (typeof(Module['_emscripten_futex_wake']) !== 'function') {
err("Thread Initialisation failed.");
throw ex;
}
#endif
// ExitStatus not present in MINIMAL_RUNTIME
#if !MINIMAL_RUNTIME
if (ex instanceof Module['ExitStatus']) {
Expand Down