Skip to content

Attempt to make test_embind_finalization less flaky #16246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Feb 10, 2022
Merged

Attempt to make test_embind_finalization less flaky #16246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/embind/test_finalization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@ Module.onRuntimeInitialized = () => {
const foo1 = new Module.Foo("Constructed from JS");
const foo2 = Module.foo();
const foo3 = Module.pFoo();
setTimeout(gc, 100);
}

setTimeout(gc, 100);
2 changes: 1 addition & 1 deletion tests/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2431,7 +2431,7 @@ def test_embind_finalization(self):
self.run_process(
[EMXX,
test_file('embind/test_finalization.cpp'),
'--post-js', test_file('embind/test_finalization.js'),
'--pre-js', test_file('embind/test_finalization.js'),
'--bind']
)
self.node_args += ['--expose-gc']
Expand Down