Don't export 'run' runtime method by default - #17383
Merged
Merged
Conversation
kripken
approved these changes
Jul 7, 2022
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
In addition, I'm not sure how important a use case it is for users to be able to call run manually. The runtime knows when to do that, but otherwise it seems very dangerous. But sounds good to allow it in theory as in this PR.
sbc100
enabled auto-merge (squash)
July 7, 2022 18:08
xbcnn
pushed a commit
to xbcnn/emscripten
that referenced
this pull request
Jul 22, 2022
Instead allow folks to export it via EXPORTED_RUNTIME_METHODS, just other similar functions such as `abort`. See emscripten-core#9334 and 4ccf542
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead allow folks to export it via EXPORTED_RUNTIME_METHODS, just
other similar functions such as
abort.See #9334 and 4ccf542