Move __cxa_allocate_exception/__cxa_free_exception to native code. NFC - #18292
Merged
Conversation
sbc100
force-pushed
the
alloc_exception
branch
2 times, most recently
from
December 1, 2022 21:09
c6de899 to
acdd703
Compare
sbc100
force-pushed
the
alloc_exception
branch
2 times, most recently
from
December 1, 2022 21:45
9aef9e9 to
05de39d
Compare
sbc100
changed the title
__cxa_allocate/free_exception to native code. NFC
sbc100
changed the title
__cxa_allocate/free_exception to native code. NFC__cxa_allocate_exception/__cxa_free_exception to native code. NFC
aheejin
reviewed
Dec 1, 2022
sbc100
force-pushed
the
alloc_exception
branch
2 times, most recently
from
December 1, 2022 22:42
b0c3551 to
43b0c32
Compare
aheejin
approved these changes
Dec 1, 2022
kripken
reviewed
Dec 1, 2022
kripken
approved these changes
Dec 1, 2022
sbc100
force-pushed
the
alloc_exception
branch
from
December 2, 2022 00:30
43b0c32 to
e4d7094
Compare
sbc100
enabled auto-merge (squash)
December 2, 2022 00:34
sbc100
force-pushed
the
alloc_exception
branch
from
December 2, 2022 03:57
e4d7094 to
fd00cb9
Compare
sbc100
force-pushed
the
alloc_exception
branch
from
December 3, 2022 00:20
fd00cb9 to
72b41ba
Compare
Member
|
Looks like this broke the binaryen emcc build, I bisected to here. See e.g. https://github.com/WebAssembly/binaryen/actions/runs/3622890462/jobs/6108128322 - now |
Collaborator
Author
I'll take a look. In general this is good since it forces us to be more precise about our dependencies. |
kripken
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Dec 5, 2022
This should unbreak the build. This is an old problem but was just noticed due to a recent emscripten change (emscripten-core/emscripten#18292).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.