Fix regression with Safari and EXPORT_NAME - #19656
Merged
Merged
Conversation
kripken
reviewed
Jun 20, 2023
|
|
||
| src = ''' | ||
| %(maybe_async)sfunction(%(EXPORT_NAME)s = {}) { | ||
| %(maybe_async)s (Module = {}) => { |
Member
There was a problem hiding this comment.
The logic is pretty complex in this function and I can't quite follow it. Can you explain why this change is valid?
Collaborator
Author
There was a problem hiding this comment.
In the case of MODULARIZE we no longer var Module = .. in shell.js because we know we can are going to receive it via the (possibly default) argument here.
In shell.js now define var {{ EXPORT_NAME }} .. locally just in case the user wants to refer to it locally by this name.. I've added a comment and a TODO about that.
kripken
reviewed
Jun 20, 2023
sbc100
force-pushed
the
fix_safari_issue
branch
9 times, most recently
from
June 21, 2023 23:59
017afaf to
3dfaf44
Compare
sbc100
enabled auto-merge (squash)
June 21, 2023 23:59
sbc100
force-pushed
the
fix_safari_issue
branch
2 times, most recently
from
June 22, 2023 00:59
90ca76f to
e40799a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #18357