Make _emscripten_run_callback_on_thread asynchronous - #22443
Merged
Conversation
stbergmann
force-pushed
the
fix-22442
branch
from
September 3, 2024 14:27
ad4ba26 to
d48bab8
Compare
...fixing a regression introduced in c41f659 "Remove use of legacy proxy API from library_html5.js. NFC (emscripten-core#20370)". Fixes: emscripten-core#22442
stbergmann
force-pushed
the
fix-22442
branch
from
September 16, 2024 12:42
d48bab8 to
17f1bb7
Compare
stbergmann
added a commit
to allotropia/emscripten
that referenced
this pull request
Sep 18, 2024
...fixing a regression introduced in c41f659 "Remove use of legacy proxy API from library_html5.js. NFC (emscripten-core#20370)". Fixes: emscripten-core#22442 (cherry-picked from 17f1bb7 at <emscripten-core#22443> "Make _emscripten_run_callback_on_thread asynchronous")
Member
Collaborator
|
I'm not totally sure if this is the best solution. I still need to do more investigation into #22442 |
Collaborator
|
Looking at the old code it does look like it was using async dispatch, so this change LGTM. |
Collaborator
|
Its a shame we can't avoid the dynamic allocation here .. |
sbc100
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...fixing a regression introduced in c41f659 "Remove use of legacy proxy API from library_html5.js. NFC (#20370)".
Fixes: #22442