Add ChangeLog entries for 64-bit integer changes - #24289
Merged
Merged
Conversation
sbc100
reviewed
May 9, 2025
sbc100
left a comment
sbc100
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, but could either of these changes be responsible for the recent failures we are seeing on the emscripten-release waterfall: https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8715382721933541089/+/u/Emscripten_testsuite__SAFE_HEAP_/stdout
(https://ci.chromium.org/p/emscripten-releases/g/main/console)
Collaborator
Author
|
Yeah that test failure looks legit, looks like |
Collaborator
Author
|
Ah I guess regular CI doesn't run the entire testsuite with SAFE_HEAP but that one does. I'll make a separate PR. |
sbc100
approved these changes
May 9, 2025
RReverser
added a commit
to RReverser/emscripten
that referenced
this pull request
May 9, 2025
This streamlines the `SAFE_HEAP` transform in acorn-optimizer. I was going to send this as a separate cleanup PR as part of my other work on acorn-optimizer, but it happens to also be the easy fix for a regression mentioned in emscripten-core#24289 and caused by emscripten-core#24283 which added support for 64-bit integers to acorn-optimizer passes. I could fix that issue separately by tweaking `unSign`, but this way we don't need to bother - the values with correct sign are now automatically retrieved by accessing the correct `HEAP*` array. I've added a regression test for the linked issue as well, which fails before this PR and passes after.
RReverser
added a commit
to RReverser/emscripten
that referenced
this pull request
May 9, 2025
This streamlines the `SAFE_HEAP` transform in acorn-optimizer. I was going to send this as a separate cleanup PR as part of my other work on acorn-optimizer, but it happens to also be the easy fix for a regression mentioned in emscripten-core#24289 and caused by emscripten-core#24283 which added support for 64-bit integers to acorn-optimizer passes. I could fix that issue separately by tweaking `unSign`, but this way we don't need to bother - the values with correct sign are now automatically retrieved by accessing the correct `HEAP*` array. I've added a regression test for the linked issue as well, which fails before this PR and passes after.
RReverser
added a commit
that referenced
this pull request
May 13, 2025
This streamlines the `SAFE_HEAP` transform in acorn-optimizer. I was going to send this as a separate cleanup PR as part of my other work on acorn-optimizer, but it happens to also be the easy fix for a regression mentioned in #24289 and caused by #24283 which added support for 64-bit integers to acorn-optimizer passes. I could fix that issue separately by tweaking `unSign`, but this way we don't need to bother - the values with correct sign are now automatically retrieved by accessing the correct `HEAP*` array. I've added a regression test for the linked issue as well, which fails before this PR and passes after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.