Initialize the stack bounds prior to checking the cookie - #24317
Merged
Conversation
Without this change reading of the cookie value calls into __asan_loadN which then tries to use SP, but SP is not yet initialzed, so the asan code itself trigger a STACK_OVERFLOW_CHECK error. This fixes the asan.test_stack test which was broken by emscripten-core#24314 but went unnoticed because we don't run all the asan tests in emscripten CI.
Collaborator
Author
|
My guess is that the reason this is needed is that the previous function (_asan_c_load_4u) did not touch SP, but the new function (__asan_loadN) does. So stack limits now need to be set prior to checkStackCookie. |
Collaborator
Yeah they get stack address for error reporting differently, since |
RReverser
reviewed
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change reading of the cookie value calls into __asan_loadN which then tries to use SP, but SP is not yet initialzed, so the asan code itself trigger a STACK_OVERFLOW_CHECK error.
This fixes the asan.test_stack test which was broken by #24314 but went unnoticed because we don't run all the asan tests in emscripten CI.