[tsgen] Fix memory64 with pthreads TS generation. - #24630
Merged
brendandahl merged 2 commits intoJul 1, 2025
Conversation
We already lower memory64 away when running TS generation, but we were not generating a lowered version of the JS which caused us to try and use a BigInt when creating the memory. Fixes emscripten-core#24623
kripken
approved these changes
Jun 30, 2025
brendandahl
force-pushed
the
tsgen-pthread-mem64
branch
from
June 30, 2025 23:33
e999555 to
41fabf3
Compare
Collaborator
Author
|
Oops, I had the wrong fixed issue number. Fixes #24620 |
sbc100
reviewed
Jul 7, 2025
| # v24, so we need to lower it away in order to execute the binary at build | ||
| # time. | ||
| # TODO Remove lowering when emsdk version of node is >= 24 and just require it. | ||
| if settings.MEMORY64: |
Collaborator
There was a problem hiding this comment.
This should probably be == 1 there and below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already lower memory64 away when running TS generation, but we were not generating a lowered version of the JS which caused us to try and use a BigInt when creating the memory.
Fixes #24623