Skip to content

Fix test_env and test_environ to expect any locale. #24632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juj merged 1 commit into from
Jun 30, 2025
Merged

Fix test_env and test_environ to expect any locale. #24632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/core/test_env.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ LOGNAME=web_user
PATH=/
PWD=/
HOME=/home/web_user
LANG=(C|en_US).UTF-8
LANG=(C|.._..).UTF-8
_=.*(/test_env.m?js|./this.program)

getenv\(PATH\): /
Expand Down
2 changes: 1 addition & 1 deletion test/core/test_environ.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ LOGNAME=web_user
PATH=/
PWD=/
HOME=/home/web_user
LANG=(C|en_US).UTF-8

@sbc100 sbc100 Jul 7, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main point of these tests is to verify that setting en_US in outer environment is respected by emscripten.

If the @with_env_modify({'LANG': 'en_US.UTF-8'}) line in the test code doesn't work on windows we should probably look into why its not works and/or disable the test under windows (with a bug open to investigate why it doesn't work).

LANG=(C|.._..).UTF-8
_=.*(/test_environ.m?js|/this.program)