Warn that SUPPORT_BIG_ENDIAN is experimental - #25058
Merged
Merged
Conversation
SUPPORT_BIG_ENDIAN is experimental
Support for big endian targets is "best effort" and not fully supported or tested.
kripken
approved these changes
Aug 26, 2025
Collaborator
|
I know this is well-intentioned, though this PR now disrupts running the E.g. I don't think that it would be productive to modify each test to account for this warning message being possibly present.. probably would be simplest to just revert this? (I don't think there have ever been people complaining about expectations around -sSUPPORT_BIG_ENDIAN so far?) |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 28, 2025
The change to make this config as experimental (emscripten-core#25058) raced with that adding of the test suite (emscripten-core#25068). Adding `-Wno-experimental` here like we do for other such configurations (e.g. wasm64).
Collaborator
Author
|
Sorry the marking as experimental raced with the adding of the new test config. Fix is in #25090 |
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
Support for big endian targets is "best effort" and not fully supported or tested. Also, as far as I'm aware there is only one or two users of this feature so I think it makes sense for it to stay as "best effort" for the foreseeable future. See emscripten-core#25042
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
…#25090) The change to make this config as experimental (emscripten-core#25058) raced with that adding of the test suite (emscripten-core#25068). Adding `-Wno-experimental` here like we do for other such configurations (e.g. wasm64).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for big endian targets is "best effort" and not fully supported or tested.
Also, as far as I'm aware there is only one or two users of this feature so I think it makes sense for it to stay as "best effort" for the foreseeable future.
See #25042