Skip to content

Add assertions on missing Wasm exports. NFC - #25541

Merged
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:export_asserts
Oct 10, 2025
Merged

Add assertions on missing Wasm exports. NFC#25541
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:export_asserts

Conversation

@sbc100

@sbc100 sbc100 commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@sbc100
sbc100 requested review from dschuff and kripken October 10, 2025 00:50
@sbc100
sbc100 merged commit 3ce72c0 into emscripten-core:main Oct 10, 2025
34 checks passed
@sbc100
sbc100 deleted the export_asserts branch October 10, 2025 21:46
stephenduong1004 added a commit to stephenduong1004/emscripten that referenced this pull request Nov 11, 2025
When using tsgen with -sASYNCIFY=1 and assertions enabled, an assertion failure occurs: `Assertion failed: missing Wasm export: asyncify_start_unwind`. This is due to emscripten-core#25541.

This change disables assertions when running tsgen to resolve the issue.
brendandahl pushed a commit to brendandahl/emscripten that referenced this pull request Dec 2, 2025
When using tsgen with -sASYNCIFY=1 and assertions enabled, an assertion failure occurs: `Assertion failed: missing Wasm export: asyncify_start_unwind`. This is due to emscripten-core#25541.

This change disables assertions when running tsgen to resolve the issue.
brendandahl added a commit that referenced this pull request Dec 3, 2025
When using `tsgen` with `-sASYNCIFY=1` and assertions enabled, an
assertion failure occurs: `Assertion failed: missing Wasm export:
asyncify_start_unwind`. This is due to
#25541.

This PR disables assertions for the `_asyncify_<x>` exports when running
`tsgen` to resolve the issue.

Continuation of #25780

---------

Co-authored-by: stephenduong1004 <stephenduong@google.com>
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
inolen pushed a commit to inolen/emscripten that referenced this pull request Feb 13, 2026
inolen pushed a commit to inolen/emscripten that referenced this pull request Feb 13, 2026
…#25899)

When using `tsgen` with `-sASYNCIFY=1` and assertions enabled, an
assertion failure occurs: `Assertion failed: missing Wasm export:
asyncify_start_unwind`. This is due to
emscripten-core#25541.

This PR disables assertions for the `_asyncify_<x>` exports when running
`tsgen` to resolve the issue.

Continuation of emscripten-core#25780

---------

Co-authored-by: stephenduong1004 <stephenduong@google.com>
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants