Add assertions on missing Wasm exports. NFC - #25541
Merged
Merged
Conversation
dschuff
approved these changes
Oct 10, 2025
stephenduong1004
added a commit
to stephenduong1004/emscripten
that referenced
this pull request
Nov 11, 2025
When using tsgen with -sASYNCIFY=1 and assertions enabled, an assertion failure occurs: `Assertion failed: missing Wasm export: asyncify_start_unwind`. This is due to emscripten-core#25541. This change disables assertions when running tsgen to resolve the issue.
brendandahl
pushed a commit
to brendandahl/emscripten
that referenced
this pull request
Dec 2, 2025
When using tsgen with -sASYNCIFY=1 and assertions enabled, an assertion failure occurs: `Assertion failed: missing Wasm export: asyncify_start_unwind`. This is due to emscripten-core#25541. This change disables assertions when running tsgen to resolve the issue.
brendandahl
added a commit
that referenced
this pull request
Dec 3, 2025
When using `tsgen` with `-sASYNCIFY=1` and assertions enabled, an assertion failure occurs: `Assertion failed: missing Wasm export: asyncify_start_unwind`. This is due to #25541. This PR disables assertions for the `_asyncify_<x>` exports when running `tsgen` to resolve the issue. Continuation of #25780 --------- Co-authored-by: stephenduong1004 <stephenduong@google.com> Co-authored-by: Alon Zakai <alonzakai@gmail.com>
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
…#25899) When using `tsgen` with `-sASYNCIFY=1` and assertions enabled, an assertion failure occurs: `Assertion failed: missing Wasm export: asyncify_start_unwind`. This is due to emscripten-core#25541. This PR disables assertions for the `_asyncify_<x>` exports when running `tsgen` to resolve the issue. Continuation of emscripten-core#25780 --------- Co-authored-by: stephenduong1004 <stephenduong@google.com> Co-authored-by: Alon Zakai <alonzakai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.