Skip to content

Conversation

@aheejin
Copy link
Member

@aheejin aheejin commented Jan 6, 2026

It looks WASM_ESM_INTEGRATION does not support sanitizers:

def asan(func):
assert callable(func)
@wraps(func)
@no_safe_heap('asan does not work with SAFE_HEAP')
@no_wasm2js('TODO: ASAN in wasm2js')
@no_wasm64('TODO: ASAN in memory64')
@no_2gb("asan doesn't support GLOBAL_BASE")
@no_esm_integration('sanitizers do not support WASM_ESM_INTEGRATION')
def decorated(self, *args, **kwargs):
return func(self, *args, **kwargs)

Currently, without this patch, these test fail:

asan.test_esm_integration
lsan.test_esm_integration
asan.test_esm_integration_main
asan.test_esm_integration_main_imported_memory

It looks `WASM_ESM_INTEGRATION` does not support sanitizers (emscripten-core#24582)
Currently, without this patch, these test fail:
```
24582lsan.test_esm_integration
asan.test_esm_integration_main_imported_memory
asan.test_esm_integration_main
asan.test_esm_integration
```
@aheejin aheejin requested a review from sbc100 January 6, 2026 08:29
@aheejin aheejin marked this pull request as ready for review January 6, 2026 08:29
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find.

I'm impressed that these decorators can be applied recursively like this!

@aheejin aheejin merged commit b60f327 into emscripten-core:main Jan 9, 2026
35 checks passed
@aheejin aheejin deleted the esm_integration_no_sanitize branch January 9, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants