Skip to content

Removed packaging.version as a dependency in test_other.py #27152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Jun 19, 2026
Merged

Removed packaging.version as a dependency in test_other.py #27152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
from pathlib import Path
from subprocess import PIPE, STDOUT

from packaging.version import Version

if __name__ == '__main__':
raise Exception('do not run this file directly; do something like: test/runner other')

Expand Down Expand Up @@ -947,10 +945,10 @@ def test_cxx_import(self, args):

@requires_ninja
def test_cmake_cxx_import_std(self):
cmake_minimum = '3.30'
cmake_minimum = (3, 30)
output = self.run_process([EMCMAKE, 'cmake', '--version'], stdout=PIPE).stdout
cmake_version = re.search(r'^cmake version (\d+(?:\.\d+)*)', output).group(1)
if Version(cmake_version) < Version(cmake_minimum):
if tuple(map(int, cmake_version.split('.'))) < cmake_minimum:
self.skipTest(f'CMake > {cmake_minimum} required ({cmake_version})')

self.run_process([EMCMAKE, 'cmake', '-GNinja', test_file('cmake/cxx_import_std')])
Expand Down
Loading