Skip to content

Temporarily skip tests to allow Binaryen roll #27258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlively merged 2 commits into from
Jul 6, 2026
Merged

Temporarily skip tests to allow Binaryen roll #27258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f1684d
Temporarily skip tests to allow Binaryen roll
tlively Jul 6, 2026
354bb8d
use @disabled
tlively Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10609,6 +10609,7 @@ def test_asyncify_escaping(self):
self.assertContained(' DOS_ReadFile(unsigned short', proc.stderr)
self.assertContained('Try using a response file', proc.stderr)

@disabled('Expected error message needs updating after the Binaryen roll')
def test_asyncify_response_file(self):
create_file('a.txt', r'''[
"DOS_ReadFile(unsigned short, unsigned char*, unsigned short*, bool)"
Expand Down Expand Up @@ -15524,6 +15525,7 @@ def test_create_preloaded_file(self):
self.do_runf('main.c', 'done\n', cflags=['-sFORCE_FILESYSTEM', '--post-js=post.js'])

@crossplatform
@disabled('Needs updates after Binaryen roll changes function name escaping')
def test_empath_split(self):
create_file('main.cpp', r'''
#include <iostream>
Expand Down
2 changes: 1 addition & 1 deletion test/third_party/googletest
Open in desktop
Submodule googletest updated 61 files
+13 −27 BUILD.bazel
+2 −2 CMakeLists.txt
+21 −28 MODULE.bazel
+12 −3 README.md
+10 −39 WORKSPACE
+29 −47 ci/linux-presubmit.sh
+4 −7 ci/macos-presubmit.sh
+13 −25 ci/windows-presubmit.bat
+50 −70 docs/advanced.md
+13 −0 docs/faq.md
+20 −53 docs/gmock_cook_book.md
+2 −2 docs/primer.md
+30 −23 docs/quickstart-bazel.md
+1 −2 docs/reference/actions.md
+2 −9 docs/reference/assertions.md
+4 −7 docs/reference/matchers.md
+1 −98 docs/reference/testing.md
+4 −32 fake_fuchsia_sdk.bzl
+18 −101 googlemock/include/gmock/gmock-actions.h
+76 −343 googlemock/include/gmock/gmock-matchers.h
+8 −8 googlemock/include/gmock/gmock-more-actions.h
+6 −4 googlemock/include/gmock/gmock-spec-builders.h
+5 −0 googlemock/include/gmock/internal/gmock-internal-utils.h
+0 −1 googlemock/include/gmock/internal/gmock-port.h
+4 −4 googlemock/src/gmock-cardinalities.cc
+7 −71 googlemock/test/gmock-actions_test.cc
+2 −2 googlemock/test/gmock-function-mocker_test.cc
+27 −210 googlemock/test/gmock-matchers-arithmetic_test.cc
+5 −131 googlemock/test/gmock-matchers-comparisons_test.cc
+19 −317 googlemock/test/gmock-matchers-containers_test.cc
+23 −82 googlemock/test/gmock-matchers-misc_test.cc
+10 −39 googlemock/test/gmock-more-actions_test.cc
+1 −1 googlemock/test/gmock-pp_test.cc
+4 −3 googlemock/test/gmock-spec-builders_test.cc
+1 −1 googlemock/test/gmock_link_test.h
+3 −3 googletest/README.md
+1 −1 googletest/cmake/internal_utils.cmake
+0 −7 googletest/include/gtest/gtest-assertion-result.h
+3 −3 googletest/include/gtest/gtest-matchers.h
+39 −95 googletest/include/gtest/gtest-param-test.h
+0 −39 googletest/include/gtest/gtest-printers.h
+65 −61 googletest/include/gtest/gtest-typed-test.h
+2 −2 googletest/include/gtest/gtest.h
+44 −40 googletest/include/gtest/internal/gtest-internal.h
+14 −48 googletest/include/gtest/internal/gtest-param-util.h
+66 −16 googletest/include/gtest/internal/gtest-port.h
+0 −4 googletest/src/gtest-internal-inl.h
+34 −157 googletest/src/gtest.cc
+17 −51 googletest/test/BUILD.bazel
+0 −38 googletest/test/googletest-fail-if-no-test-linked-test-with-disabled-test_.cc
+0 −38 googletest/test/googletest-fail-if-no-test-linked-test-with-enabled-test_.cc
+0 −169 googletest/test/googletest-fail-if-no-test-linked-test.py
+0 −19 googletest/test/googletest-filter-unittest.py
+16 −95 googletest/test/googletest-json-output-unittest.py
+0 −70 googletest/test/googletest-param-test-test.cc
+1 −31 googletest/test/googletest-printers-test.cc
+2 −2 googletest/test/googletest-setuptestsuite-test_.cc
+4 −52 googletest/test/gtest_unittest.cc
+26 −67 googletest/test/gtest_xml_output_unittest.py
+1 −21 googletest/test/gtest_xml_output_unittest_.cc
+7 −7 googletest_deps.bzl