Use shlex.split for executables in config file. - #27397
Merged
Merged
Conversation
sbc100
force-pushed
the
config_split
branch
2 times, most recently
from
July 21, 2026 23:25
c50e3c9 to
1f917c1
Compare
kripken
reviewed
Jul 21, 2026
| return x | ||
| return [x] | ||
| if type(x) is list: | ||
| logger.warning(f'Found list-style config entry ({x}). Please use a single string with spaces between args.') |
Member
There was a problem hiding this comment.
I'm not opposed to this warning, but I think it will start to show for many of our users?
Collaborator
Author
There was a problem hiding this comment.
I don't think its will since the default config (i.e. tools/config_template.py has not used this syntax in the long time).
I think the last usage of this in the config template was the SPIDERMONKEY_ENGINE entry which was removed in 2019: #9469
What users are you thinking of?
Member
There was a problem hiding this comment.
I was thinking of old installs which might have older versions of the config template. I guess maybe that's rare, though, if people reinstall every few years anyhow (new machine, etc.)
This allows simple strings like: ``` NODE_JS = '/path/to/node --with-arg' ``` Rather than the harder-to-parse: ``` NODE_JS = ['/path/to/node', '--with-arg'] ``` The idea is that perhaps we can just simplify our existing config format rather then converting to completely new one. See emscripten-core#27219
kripken
approved these changes
Jul 22, 2026
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
Maybe we can land it and see if tot users complain.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jul 27, 2026
…ig file This ended up breaking emsdk in ways that would require more complexity to fix. See emscripten-core/emsdk#1752. This issue is that if emsdk is installed in the path contains spaces the NODE_JS path, for example, then needs to be quoted correctly in the config file. e.g. `NODE_JS = '"path with spaces/bin/node"'. Instead I think we should just revert this change. It turns out not to be needed for emscripten-core#27401 anyway since the LLVM_ROOT is never a list anyway.
sbc100
added a commit
that referenced
this pull request
Jul 27, 2026
This ended up breaking emsdk in ways that would require more complexity to fix. See emscripten-core/emsdk#1752. This issue is that if emsdk is installed in the path contains spaces the NODE_JS path, for example, then needs to be quoted correctly in the config file. e.g. `NODE_JS = '"path with spaces/bin/node"'. Instead I think we should just revert this change. It turns out not to be needed for #27401 anyway since the LLVM_ROOT is never a list anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows simple strings like:
Rather than the harder-to-parse:
The idea is that perhaps we can just simplify our existing config format rather then converting to completely new one.
See #27219