Cleanup src/lib/libopenal.js. NFC - #27425
Merged
Merged
Conversation
kripken
reviewed
Jul 28, 2026
kripken
reviewed
Jul 28, 2026
kripken
reviewed
Jul 29, 2026
- Use `for .. of` in a few more places. - Remove duplication in setSourceParam(AL_BUFFER)
sbc100
changed the title
kripken
approved these changes
Jul 29, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jul 29, 2026
Similar to emscripten-core#27425 but applied to the whole JS library - Replace explicit zero checks (`=== 0`, `!== 0`) with implicit truthy/falsy checks (`!x`, `x`). - Replace `.length === 0` checks with `!arr.length`. - Simplify null/undefined/zero check in `src/lib/libccall.js` to `if (str)`. - Use `for (var byte of data)` loop in `src/lib/libbrowser.js`.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jul 30, 2026
Similar to emscripten-core#27425 but applied to the whole JS library - Replace explicit zero checks (`=== 0`, `!== 0`) with implicit truthy/falsy checks (`!x`, `x`). - Replace `.length === 0` checks with `!arr.length`. - Simplify null/undefined/zero check in `src/lib/libccall.js` to `if (str)`. - Use `for (var byte of data)` loop in `src/lib/libbrowser.js`.
sbc100
added a commit
that referenced
this pull request
Jul 30, 2026
Similar to #27425 but applied to the whole JS library - Replace explicit zero checks (`=== 0`, `!== 0`) with implicit truthy/falsy checks (`!x`, `x`). - Replace `.length === 0` checks with `!arr.length`. - Simplify null/undefined/zero check in `src/lib/libccall.js` to `if (str)`. - Use `for (var byte of data)` loop in `src/lib/libbrowser.js`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for .. ofin a few more places.!== 0and=== 0